libglnx porting: Migrate from GSConsole
authorColin Walters <walters@verbum.org>
Sun, 1 May 2016 18:22:52 +0000 (14:22 -0400)
committerColin Walters (automation) <walters+githubbot@verbum.org>
Mon, 2 May 2016 11:41:00 +0000 (11:41 +0000)
commita6c731f6e7d1014aab5989c98a6432d28080905b
tree7bd80f0c1024770e1eb5cbdb304daa2492e02170
parent831e9dcdeac28b56c29e84f58ae90fb70e73626c
libglnx porting: Migrate from GSConsole

To GLnxConsoleRef.  There were some subtleties here, for example we
used to reference `GSConsole` inside the progress changed function,
which at first seems like an ABI hazard, because e.g. rpm-ostree or
xdg-app could still be passing a `GSConsole` instance there.  Luckily,
it turns out to be compatible to just start calling libglnx here.

Another issue was that due to libglnx's use of the cleanup function,
we needed to ensure we always called `ostree_async_progress_finish()`
*before* the cleanup function was invoked.

Closes: #280
Approved by: giuseppe
libglnx
src/libostree/ostree-repo.c
src/ostree/ot-admin-builtin-switch.c
src/ostree/ot-admin-builtin-upgrade.c
src/ostree/ot-builtin-pull-local.c
src/ostree/ot-builtin-pull.c